Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 upgrade golangci-lint to v1.61.0 #2950

Merged
merged 8 commits into from
Oct 11, 2024
Merged

🐛 upgrade golangci-lint to v1.61.0 #2950

merged 8 commits into from
Oct 11, 2024

Conversation

sivchari
Copy link
Member

Upgade the golangci-lint version to v1.61.0.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2024
@sivchari sivchari changed the title upgrade golangci-lint to v1.61.0 🐛 upgrade golangci-lint to v1.61.0 Sep 17, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2024
@sivchari sivchari force-pushed the upgrade-golangci branch 3 times, most recently from b497534 to e96da8a Compare September 18, 2024 04:14
sbueringer
sbueringer reviewed Sep 21, 2024
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2024
@sivchari sivchari force-pushed the upgrade-golangci branch 2 times, most recently from bdef91f to dbfe115 Compare October 2, 2024 03:04
sbueringer
sbueringer reviewed Oct 6, 2024
View reviewed changes
pkg/log/zap/flags.go Outdated Show resolved Hide resolved
pkg/webhook/admission/response.go Outdated Show resolved Hide resolved
tools/setup-envtest/store/store.go Outdated Show resolved Hide resolved
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 6, 2024
@sbueringer
Copy link
Member

@sivchari Do you have time to address the findings? I might need this PR so I can bump to Kubernetes v1.32 alpha.1

@sbueringer sbueringer mentioned this pull request Oct 9, 2024
Merged
@sivchari @sbueringer
upgrade golangci-lint to v1.61.0
2732ab9 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari @sbueringer
apply nolintlint
cc145e2 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari @sbueringer
disable gosec G115
e04c2f0 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari @sbueringer
revert configuration
6dcfe17 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari @sbueringer
clean up comments
96513c1 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari @sbueringer
add nolint:gosec about G115 rule
9d07df7 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari @sbueringer
fix: gofmt
fff8ec8 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sbueringer
Copy link
Member

sbueringer commented Oct 11, 2024 •
edited
Loading

Pushed a small commit to fix the remaining findings

/assign @alvaroaleman @vincepri

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 87d1795e2309fe85aa424722590c3cb873d1b03a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sivchari, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4698370 into kubernetes-sigs:main Oct 11, 2024
9 checks passed
@sivchari
Copy link
Member Author

@sbueringer
cc. @vincepri
Thanks, I didn't have time to work on it, so I appreciate it so much.

@sbueringer
Copy link
Member

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@vincepri vincepri vincepri approved these changes

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

Assignees

@vincepri vincepri

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sivchari @sbueringer @k8s-ci-robot @vincepri @alvaroaleman