Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Revert "🌱 Bump github.com/prometheus/client_golang" #2750

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

twz123
Copy link
Contributor

@twz123 twz123 commented Apr 2, 2024

This reverts PR #2699.

The bump of github.com/prometheus/common to v0.48.0 is incompatible with upstream Kubernetes, which uses v0.44.0. Kubernetes uses a public symbol which has been made private in v0.48.0.

Fixes #2742.

This reverts commit f7f3d1e.

The bump of github.com/prometheus/common to v0.48.0 is incompatible with
upstream Kubernetes, which uses v0.44.0. Kubernetes uses a public symbol
which has been made private in v0.48.0.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @twz123. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2024
@sbueringer
Copy link
Member

/ok-to-test

I'll try to look into it tomorrow

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 2, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, twz123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0446590 into kubernetes-sigs:main Apr 3, 2024
9 checks passed
@twz123 twz123 deleted the revert-2699 branch April 3, 2024 08:19
@twz123 twz123 mentioned this pull request Apr 18, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github.com/prometheus/common v0.48.0 is incompatible with Kubernetes
4 participants