Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Downgrade prometheus client libs to versions used in k/k 1.30 #2765

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 9, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2024
@sbueringer
Copy link
Member Author

/assign @vincepri @alvaroaleman

We recently had some problems when upgrading even further. But I think we should play it safe and use the exact same versions that k/k is using.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b8da5868640810a3dba865a8f7a3d29ee927ff88

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 01f3f84 into kubernetes-sigs:main Apr 9, 2024
9 checks passed
@sbueringer sbueringer deleted the pr-downgrade-prom branch April 9, 2024 13:35
@aerfio
Copy link
Contributor

aerfio commented Apr 10, 2024

We recently had some problems when upgrading even further. But I think we should play it safe and use the exact same versions that k/k is using.

@sbueringer could you please provide a link to an issue/PR which explains those problems? Thanks

@vincepri
Copy link
Member

As a general rule we match controller-runtime dependencies with upstream ones, if possible. @sbueringer we might want to add a validation script to keep them in sync

@sbueringer
Copy link
Member Author

@aerfio The initial problem we found in this context was this: #2750

Nobody complained yet about the diff we had after this PR, but it might just be a matter of time until someone uses another package where additional errors pop up. So to play it safe we try to keep the dependencies in sync to avoid compile errors when folks start adopting a new CR version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants