-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Downgrade prometheus client libs to versions used in k/k 1.30 #2765
🌱 Downgrade prometheus client libs to versions used in k/k 1.30 #2765
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
/assign @vincepri @alvaroaleman We recently had some problems when upgrading even further. But I think we should play it safe and use the exact same versions that k/k is using. |
LGTM label has been added. Git tree hash: b8da5868640810a3dba865a8f7a3d29ee927ff88
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer could you please provide a link to an issue/PR which explains those problems? Thanks |
As a general rule we match controller-runtime dependencies with upstream ones, if possible. @sbueringer we might want to add a validation script to keep them in sync |
@aerfio The initial problem we found in this context was this: #2750 Nobody complained yet about the diff we had after this PR, but it might just be a matter of time until someone uses another package where additional errors pop up. So to play it safe we try to keep the dependencies in sync to avoid compile errors when folks start adopting a new CR version |
Signed-off-by: Stefan Büringer buringerst@vmware.com