✨ util: Warning handler that discards messages that match a regular expression #11179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/util
k8s-ci-robot
added
the
size/L
sbueringer
reviewed
Sep 17, 2024
…gular expression Remove deduplication. As a side-effect, simplify the implementation.
sbueringer
reviewed
Sep 19, 2024
…gular expression Fix the test of an uninitialized handler, so that the logger is exercised.
…gular expression Split conflated test case into two independent test cases
sbueringer
added
the
tide/merge-method-squash
|
Thank you very much! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 678c3eb16b75827463f6f4f0f032c53b89abd46e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As described in #10932 and #11065, users see API server warnings from run
clusterctl move, and in controller logs. We want to offer users the option of hiding these warnings. The warning handler available in client-go allows us to hide all warnings, but we want to hide only specific warnings.This PR implements a handler that we can customize to our needs. Because Cluster API providers are affected by this issue, we define the handler in a new
util/apiwarningspackage that can be used by providers, which are typically consumers of thecluster-apigo module.Future PRs will use this handler to hide warnings in the
clusterctl movecommand, and controller logs.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area util