Skip to content

Consider filtering out finalizer warnings in controller logs #11065

Closed
@sbueringer

Description

@sbueringer

Context:

The warnings we get today in our controllers look like this:

{"ts":1724055396150.5093,"logger":"KubeAPIWarningLogger","caller":"log/warning_handler.go:65","msg":"metadata.finalizers: "addons.cluster.x-k8s.io": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers","v":0}

As we are aware of the "problem" and it will take us a while to migrate away from our current finalizers, I think we should consider to filter out the warnings in our controller logs.

Today logging the warnings produces a lot of spam and nobody that is running Cluster API can do anything about it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/loggingIssues or PRs related to loggingkind/featureCategorizes issue or PR as related to a new feature.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions