Skip to content

Update klog dependency to v2 #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2021
Merged

Update klog dependency to v2 #1231

merged 2 commits into from
Mar 17, 2021

Conversation

@stmcginnis
Copy link
Contributor

What this PR does / why we need it:

The klog v1 dependency used is quite old now, and the k/k repo has
switched to more recent v2 versions for quite some time now.

This updates klog usage to use the v2 package version.

Special notes for your reviewer:

This is part of an overall effort along with updating the k-sigs/cluster-api repo here:

kubernetes-sigs/cluster-api#4284

Release note:

NONE

/kind cleanup

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @stmcginnis!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/provider/azure Issues or PRs related to azure provider labels Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @stmcginnis. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2021
@nader-ziada
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2021
@CecileRobertMichon
Copy link
Contributor

should we wait until kubernetes-sigs/cluster-api#4284 is merged and bump the capi nightly build version before doing this?

@nader-ziada
Copy link
Contributor

@stmcginnis would you mind updating the capi nightly release used in capz as part of this PR as well?

we can use nightly_master_20210315

The capi release is mentioned in 3 files:

  • Makefile
  • Tiltfile
  • test/e2e/config/azure-dev.yaml

@nader-ziada
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 15, 2021
@stmcginnis
Copy link
Contributor Author

Rebased on master to pick up some other changes to the Tiltfile.

@stmcginnis
Copy link
Contributor Author

Job failures don't look related to this change.

/test pull-cluster-api-provider-azure-e2e

@stmcginnis
Copy link
Contributor Author

ERROR: (AuthenticationFailed) Authentication failed.

Definitely not related to this change. Third times a charm?

/test pull-cluster-api-provider-azure-e2e

@nader-ziada
Copy link
Contributor

nader-ziada commented Mar 15, 2021 •
edited
Loading

ERROR: (AuthenticationFailed) Authentication failed.

Definitely not related to this change. Third times a charm?

/test pull-cluster-api-provider-azure-e2e

we think its because of an Azure AAD issue, waiting for it to be resolved

@nader-ziada
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e

@CecileRobertMichon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2021
@nader-ziada
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nader-ziada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2021
@nader-ziada
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e-windows

@stmcginnis
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-windows

Test timeout.

@devigned
Copy link
Contributor

/retest

@stmcginnis
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-windows

@stmcginnis
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e

Whack a mole. :)

@CecileRobertMichon
Copy link
Contributor

Looks like we're getting hit by quota issues in the CNCF sub, I'm looking into it

E0316 20:55:14.568097       1 controller.go:302] controller-runtime/manager/controller/azuremachine "msg"="Reconciler error" "error"="failed to reconcile AzureMachine: failed to create virtual machine: failed to create VM capz-e2e-jv25q7-control-plane-x4gs5 in resource group capz-e2e-jv25q7: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code=\"OperationNotAllowed\" Message=\"Operation could not be completed as it results in exceeding approved standardDSv3Family Cores quota. Additional details - Deployment Model: Resource Manager, Location: southcentralus, Current Limit: 220, Current Usage: 220, Additional Required: 2, (Minimum) New Limit Required: 222. Submit a request for Quota increase at https://aka.ms/ProdportalCRP/?#create/Microsoft.Support/Parameters/%7B%22subId%22:%22===REDACTED===%22,%22pesId%22:%2206bfd9d3-516b-d5c6-5802-169c800dec89%22,%22supportTopicId%22:%22e12e3d1d-7fa0-af33-c6d0-3c50df9658a3%22%7D by specifying parameters listed in the ‘Details’ section for deployment to succeed. Please read more about quota limits at https://docs.microsoft.com/en-us/azure/azure-supportability/per-vm-quota-requests.\"" "name"="capz-e2e-jv25q7-control-plane-x4gs5" "namespace"="create-workload-cluster-qrxh3z" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="AzureMachine"

@CecileRobertMichon
Copy link
Contributor

Opened #1245 to mitigate

@CecileRobertMichon
Copy link
Contributor

#1245 has merged, please rebase to fix quota issues

@stmcginnis
Update klog dependency to v2
6fd67de 
This switches klog usage over to klog v2.5.0 to match the current
version being used in k/k.

This should also address some issues we're seeing that have since been
fixed in klog between the quite old v1.0.0 and v2.5.0

Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
@stmcginnis
Bump CAPI release to nightly_master_20210315
e28a93b 
This updates the CAPI release used to the more recent
nightly_master_20210315 build.

Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2021
@stmcginnis
Copy link
Contributor Author

Rebased to pick up the latest.

@CecileRobertMichon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 63bd284 into kubernetes-sigs:master Mar 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.5.0 milestone Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@devigned devigned Awaiting requested review from devigned

Assignees

@nader-ziada nader-ziada

@CecileRobertMichon CecileRobertMichon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v0.5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@stmcginnis @k8s-ci-robot @nader-ziada @CecileRobertMichon @devigned