Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛: fix unknown provider errors when using fetchConfigs #730

Merged
merged 6 commits into from
Mar 11, 2025
+30,802 −25
Merged

🐛: fix unknown provider errors when using fetchConfigs #730

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2dc4296
🐛: fix unknown provider errors with fetchConfigs
w21froster Feb 25, 2025
02da990
nit: remove debugging line
w21froster Feb 26, 2025
53b604a
chore: relocate GetCustomProviders to util, fix some naming
w21froster Feb 26, 2025
cc7397b
chore: use genericProviderList type to avoid casting twice
w21froster Feb 26, 2025
de29d47
nit: avoid shadowing genericProviderList type
w21froster Feb 26, 2025
b98394f
nit: explicitly call out that the function grabs custom providers
w21froster Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nit: avoid shadowing genericProviderList type
  • Loading branch information
@w21froster
w21froster committed Mar 3, 2025
commit de29d47af665b9afd9da3bdbec7cb87a7f4433b0
10 changes: 5 additions & 5 deletions util/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,22 +77,22 @@ func GetCustomProviders(ctx context.Context, cl ctrlclient.Client, currProvider
currProviderType := currProvider.GetType()

for _, providerList := range operatorv1.ProviderLists {
genericProviderList, ok := providerList.(genericProviderList)
genProviderList, ok := providerList.(genericProviderList)
if !ok {
return nil, fmt.Errorf("cannot cast providers list to genericProviderList")
}

if err := cl.List(ctx, genericProviderList); err != nil {
if err := cl.List(ctx, genProviderList); err != nil {
return nil, fmt.Errorf("cannot get a list of providers from the server: %w", err)
}

genericProviderListItems := genericProviderList.GetItems()
for i, provider := range genericProviderListItems {
genProviderListItems := genProviderList.GetItems()
for i, provider := range genProviderListItems {
if provider.GetName() == currProviderName && provider.GetType() == currProviderType || provider.GetSpec().FetchConfig == nil {
continue
}

customProviders = append(customProviders, genericProviderListItems[i])
customProviders = append(customProviders, genProviderListItems[i])
}
}

Expand Down