Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛: fix unknown provider errors when using fetchConfigs #730

Conversation

w21froster
Copy link
Contributor

What this PR does / why we need it:
When using fetchConfig in the provider spec for multiple providers, the operator does not properly pass information about other "custom" providers to the clusterctl configuration. Currently, the operator passes repository information about the current provider only, and the default list from clusterctl. This causes clusterctl to fail it's lagging provider check, which is intended to keep providers within a valid version skew to avoid a broken cluster, and prevents upgrading providers when using fetchConfig in multiple places.

This PR adds information about other providers that are using fetchConfig to the MemoryReader, so that clusterctl can properly pass this check.

Which issue(s) this PR fixes:
Fixes #570

Copy link

linux-foundation-easycla bot commented Feb 22, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 22, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @w21froster!

It looks like this is your first PR to kubernetes-sigs/cluster-api-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @w21froster. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2025
Copy link

netlify bot commented Feb 22, 2025

Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit b98394f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/67c609fe61b5460008e7e5cb
😎 Deploy Preview https://deploy-preview-730--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@w21froster w21froster force-pushed the fix-lagging-provider-check-failure branch from 027aa16 to 1ea2724 Compare February 22, 2025 23:18
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 22, 2025
@dmvolod
Copy link
Member

dmvolod commented Feb 25, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 25, 2025
@w21froster w21froster force-pushed the fix-lagging-provider-check-failure branch from fb16c02 to 6879721 Compare February 26, 2025 00:00
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2025
@w21froster w21froster changed the title 🐛: fix lagging provider check failure when using custom fetchConfig 🐛: fix unknown provider errors when using fetchConfigs Feb 26, 2025
@w21froster
Copy link
Contributor Author

/retest

@furkatgofurov7
Copy link
Member

/test?

@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: The following commands are available to trigger required jobs:

/test pull-cluster-api-operator-build-main
/test pull-cluster-api-operator-e2e-main
/test pull-cluster-api-operator-make-main
/test pull-cluster-api-operator-test-main
/test pull-cluster-api-operator-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-operator-apidiff-main

Use /test all to run all jobs.

In response to this:

/test?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@furkatgofurov7
Copy link
Member

/test pull-cluster-api-operator-e2e-main

@w21froster
Copy link
Contributor Author

This PR is ready for a final review whenever you folks have a chance, let me know if there is anything else I can fix / update here. I appreciate your help! 🙏

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2025
@w21froster w21froster force-pushed the fix-lagging-provider-check-failure branch from 5aa6a2b to b98394f Compare March 3, 2025 19:58
@w21froster
Copy link
Contributor Author

Hey folks, sorry for the bump, anything else needed from me on this PR to get the LGTM? I went ahead and rebased off main. Thank you 🙇

@furkatgofurov7
Copy link
Member

This is a huge patch, however, it is due to manifests included and changes are inside the test folder anyways, so I am merging it.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 68418b1740f8415fc9c29d109ac3f6358b3c423f

@furkatgofurov7
Copy link
Member

Thanks @w21froster working on the fix, appreciated 🥇

@k8s-ci-robot k8s-ci-robot merged commit 1b8ddbd into kubernetes-sigs:main Mar 11, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to upgrade providers when using custom fetchconfig
4 participants