-
Notifications
You must be signed in to change notification settings - Fork 108
🐛 Add generate workflow for full-chart-install test case #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add generate workflow for full-chart-install test case #212
Conversation
e07f0cc
to
9876381
Compare
/test pull-cluster-api-operator-test-main |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
service: | ||
name: capi-operator-webhook-service | ||
namespace: 'capi-operator-system' | ||
namespace: 'default' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why is this needed for generating full chart?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the default state of the chart, instead of giving it some namespace I left out all variable substitutions on default. This is what user sees when they do helm install capi-operator capi-operator/cluster-api-operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 62d70917cdb3a122737b44242b4b31f2ca842103
|
What this PR does / why we need it:
Addressing outstanding task in #207 (comment)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #