🌱 Refactor tests to be more readable and have better logging #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
Danil-Grigorev
changed the title
Danil-Grigorev
force-pushed
the
init-logs-suite
branch
from
cab3fd7 to
5fdcfde
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| @@ -0,0 +1,6775 @@ | |||
| --- | |||
| # Source: cluster-api-operator/templates/operator-components.yaml | |||
| apiVersion: apiextensions.k8s.io/v1 | |||
There was a problem hiding this comment.
can this file be updated as a part of make generate? I assume the tests will break each time we add a new API change. It can be done in a follow-up PR
There was a problem hiding this comment.
I fixed this in #212
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d952bcb0a1e58847042af2fdf2db4dfaef92434c
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a test framework package for helper methods
Adds test for tracking chart changes in helm installation process mentioned in helm-chart-quick-start
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #