Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@detiber
Copy link
Contributor

@detiber detiber commented Apr 27, 2021

What this PR does / why we need it:

Updates providerID to "equinixmetal" instead of "packet", this aligns with newer versions of cloud-provider-equinix-metal.

Related to: #227
WIP upgrade instructions here: https://gist.github.com/detiber/12d2ebae99159f296fe8cf6a0321971e

Current (as of May 21st 10:30am ET) demo of the migration tool: https://asciinema.org/a/S3gvvT9rrRaEz6ZpdamgZp5W8#

Outstanding work:

  • Fix scrolling output for per-cluster output that exceeds the window size
  • Add legend for interacting with UI (pagination and scrolling)
  • Improve dry run output to include diff
  • Write out yaml to manually create a node if re-creation fails within the tool
  • Improve pre-requisite output to tell users to run the steps in the correct order with the correct commands
  • Potentially publish a container image for running the tool in addition to the binary
  • Release notes/Documentation
  • Update color use to be adaptive based on background color

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 27, 2021
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 20, 2021
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 26, 2021
@k8s-ci-robot
Copy link
Contributor

@detiber: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2021
@detiber detiber mentioned this pull request Jul 23, 2021
8 tasks
@detiber
Copy link
Contributor Author

detiber commented Sep 10, 2021

/close
closing in favor of #269 that includes this work

@k8s-ci-robot
Copy link
Contributor

@detiber: Closed this PR.

In response to this:

/close
closing in favor of #269 that includes this work

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants