Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@rawkode
Copy link
Contributor

@rawkode rawkode commented Feb 23, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 23, 2021
@rawkode
Copy link
Contributor Author

rawkode commented Feb 23, 2021

/assign @detiber

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: displague, rawkode
To complete the pull request process, please ask for approval from detiber after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@displague
Copy link
Contributor

@detiber
Copy link
Contributor

detiber commented Apr 21, 2021

@displague I can also handle that as a followup, I'm working on verifying things related to upgrades with updating to a newer version of the CCM

Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we are pulling from raw.githubusercontent.com (ie from the tree) and not from the releases section? I guess it doesn't really matter - both pull down the same content - but isn't releases the "official" place to go?

@detiber detiber mentioned this pull request Apr 27, 2021
8 tasks
@displague
Copy link
Contributor

@deitch makes a good point. The releases are build artifacts that we can update if needed. While that may be bad practice, especially without reporting the checksums, this does offer a way to fix bad past releases. Pinning to tags does not allow that (unless we force-move the tag 😬 )

@k8s-triage-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 2, 2021
@detiber
Copy link
Contributor

detiber commented Sep 8, 2021

Closing in favor of #269, which includes additional fixes and migration tooling needed to properly upgrade the CCM
/close

@k8s-ci-robot
Copy link
Contributor

@detiber: Closed this PR.

In response to this:

Closing in favor of #269, which includes additional fixes and migration tooling needed to properly upgrade the CCM
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants