-
Couldn't load subscription status.
- Fork 42
chore: update to CCM 3.0.1 #227
Conversation
|
/assign @detiber |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: displague, rawkode The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rawkode perhaps we should update this to https://github.com/equinix/cloud-provider-equinix-metal/releases/tag/v3.1.0 |
|
@displague I can also handle that as a followup, I'm working on verifying things related to upgrades with updating to a newer version of the CCM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we are pulling from raw.githubusercontent.com (ie from the tree) and not from the releases section? I guess it doesn't really matter - both pull down the same content - but isn't releases the "official" place to go?
|
@deitch makes a good point. The releases are build artifacts that we can update if needed. While that may be bad practice, especially without reporting the checksums, this does offer a way to fix bad past releases. Pinning to tags does not allow that (unless we force-move the tag 😬 ) |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
|
Closing in favor of #269, which includes additional fixes and migration tooling needed to properly upgrade the CCM |
|
@detiber: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #