Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volume mode conversion flag to snapshot-controller manifest #790

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Add volume mode conversion flag to snapshot-controller manifest #790

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3309c8a
Add volume mode conversion flag to manifests
RaunakShah Nov 18, 2022
9d4ad3f
Add marker
RaunakShah Nov 29, 2022
8cc3b4d
Add marker description
RaunakShah Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,5 @@ spec:
args:
- "--v=5"
- "--leader-election=true"
# end snapshot controller args
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the following comments here so we remember not to remove this?

Adds a marker to the snapshot-controller manifests. This is needed to enable feature gates in CSI prow jobs. In https://github.com/kubernetes-csi/csi-release-tools/pull/209, the snapshot-controller YAML is updated to add --prevent-volume-mode-conversion=true so that the feature can be enabled for certain e2e tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

imagePullPolicy: IfNotPresent