Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volume mode conversion flag to snapshot-controller manifest #790

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Add volume mode conversion flag to snapshot-controller manifest #790

merged 3 commits into from
Jan 4, 2023

Conversation

RaunakShah
Copy link
Contributor

@RaunakShah RaunakShah commented Nov 22, 2022 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds a marker to the snapshot-controller manifests. This is needed to enable feature gates in CSI prow jobs. In kubernetes-csi/csi-release-tools#209, the snapshot-controller YAML is updated to add --prevent-volume-mode-conversion=true so that the feature can be enabled for certain e2e tests.
Also related to kubernetes-csi/csi-driver-host-path#379

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add a marker to the snapshot-controller manifests to enable feature gates in CSI prow jobs.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2022
@RaunakShah RaunakShah mentioned this pull request Nov 22, 2022
Closed
@pohly
Copy link
Contributor

pohly commented Nov 24, 2022

This is needed to enable this feature in e2e tests using these manifests.

That's not enough for me to understand why this flag is needed. Can you add an explanation, ideally in the commit message?

@RaunakShah RaunakShah changed the title [WIP] Add volume mode conversion flag to snapshot-controller manifest Add volume mode conversion flag to snapshot-controller manifest Nov 28, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 29, 2022
@RaunakShah
Copy link
Contributor Author

/release-note none

ggriffiths
ggriffiths suggested changes Dec 8, 2022
View reviewed changes
Copy link
Member

@ggriffiths ggriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fragile for a test to depend on a comment in a yaml file. I would instead suggest parsing the yaml if you need to do this in the tests

@RaunakShah RaunakShah mentioned this pull request Dec 9, 2022
Merged
@RaunakShah
Copy link
Contributor Author

@ggriffiths This seems like the simplest solution to have our existing prow jobs run local e2e test suites without any major changes to the scripts. Here's some previous discussion we had on this topic and why updating the feature flags on the go (in the tests) may not be feasible - kubernetes-csi/csi-release-tools#206 (comment)

I could add a disclaimer here stating the importance of keeping this line

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 22, 2022
@RaunakShah
Copy link
Contributor Author

@pohly can we merge this to unblock kubernetes-csi/external-provisioner#832?

pohly
pohly approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2023
xing-yang
xing-yang reviewed Jan 2, 2023
View reviewed changes
deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml
@@ -37,4 +37,5 @@ spec:
args:
- "--v=5"
- "--leader-election=true"
# end snapshot controller args
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the following comments here so we remember not to remove this?

Adds a marker to the snapshot-controller manifests. This is needed to enable feature gates in CSI prow jobs. In https://github.com/kubernetes-csi/csi-release-tools/pull/209, the snapshot-controller YAML is updated to add --prevent-volume-mode-conversion=true so that the feature can be enabled for certain e2e tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@xing-yang
Copy link
Collaborator

@RaunakShah Please add a release note.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 3, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2023
@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, RaunakShah, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit e9b652c into kubernetes-csi:master Jan 4, 2023
@mpatlasov mpatlasov mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@ggriffiths ggriffiths ggriffiths requested changes

@pohly pohly pohly approved these changes

@humblec humblec Awaiting requested review from humblec

Assignees

@pohly pohly

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RaunakShah @pohly @xing-yang @k8s-ci-robot @ggriffiths