Skip to content

Conversation

sheldonkwok
Copy link
Contributor

@sheldonkwok sheldonkwok commented Feb 1, 2019

The types seem to have drifted back into the devDependencies from when I moved them over originally in #39
Reasoning: microsoft/types-publisher#81 (comment)
I'm happy to rebase after related pull requests go through.

Related:
#156
#160
#200
#201

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 1, 2019
@brendandburns
Copy link
Contributor

@sheldonkwok this generally looks good, but we're removing bluebird b/c it breaks es6 users.

@sheldonkwok
Copy link
Contributor Author

No problem, I can rebase after that one is merged or do it here if you want

@sheldonkwok sheldonkwok force-pushed the fix/move-types-to-deps branch 2 times, most recently from 04edacf to 658e5da Compare February 2, 2019 01:29
@sheldonkwok
Copy link
Contributor Author

Rebased

@sheldonkwok sheldonkwok force-pushed the fix/move-types-to-deps branch from 658e5da to c879dda Compare February 2, 2019 01:31
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2019
@drubin
Copy link
Contributor

drubin commented Feb 2, 2019

/lgtm

I have been wondering if it's worth adding a note to the readme about where to put @types definitions. It seems we have gone back and forth between devDeps and Deps a few times in the last few months.

What do you think maybe a simple metric like any return value from a public function needs to be in deps else they should go into devdeps

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2019
@sheldonkwok
Copy link
Contributor Author

That sounds good but it might be harder to keep track of if things get pretty nested. An easy way might just be: Every dep should have its @types also be in the dep.

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, sheldonkwok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit ef46c77 into kubernetes-client:master Feb 4, 2019
@sheldonkwok sheldonkwok deleted the fix/move-types-to-deps branch February 4, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants