-
Notifications
You must be signed in to change notification settings - Fork 557
Move appropriate @types back to dependencies #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move appropriate @types back to dependencies #202
Conversation
@sheldonkwok this generally looks good, but we're removing bluebird b/c it breaks es6 users. |
No problem, I can rebase after that one is merged or do it here if you want |
04edacf
to
658e5da
Compare
Rebased |
658e5da
to
c879dda
Compare
/lgtm I have been wondering if it's worth adding a note to the readme about where to put What do you think maybe a simple metric like any return value from a public function needs to be in deps else they should go into devdeps |
That sounds good but it might be harder to keep track of if things get pretty nested. An easy way might just be: Every dep should have its @types also be in the dep. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, sheldonkwok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The types seem to have drifted back into the devDependencies from when I moved them over originally in #39
Reasoning: microsoft/types-publisher#81 (comment)
I'm happy to rebase after related pull requests go through.
Related:
#156
#160
#200
#201