Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @types to package.json dependencies for definitions and add missing @types #39

Merged
merged 4 commits into from
Apr 25, 2018

Conversation

sheldonkwok
Copy link
Contributor

We need the module's dependency's types in the dependencies part of the package.json for typescript to see them. More reasoning can be found here: microsoft/types-publisher#81

@sheldonkwok sheldonkwok mentioned this pull request Apr 20, 2018
@sheldonkwok
Copy link
Contributor Author

sheldonkwok commented Apr 20, 2018

I just signed up for the CNCF CLA but I'm not sure how to retrigger w/o another commit.

Edit: I guess this comment works.

@sheldonkwok sheldonkwok changed the title Move @types to package.json dependencies for definitions Move @types to package.json dependencies for definitions and add missing @types Apr 21, 2018
@sheldonkwok
Copy link
Contributor Author

Adding the @types to the dependencies itself didn't work. I ended up having to add new @types and change code.

@sheldonkwok
Copy link
Contributor Author

Closes #37

@brendandburns
Copy link
Contributor

LGTM, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants