Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shortcut for iitem #883

Merged
merged 2 commits into from
Sep 21, 2022
Merged

shortcut for iitem #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8bed9f
shortcut for iitem
tg123 Jun 3, 2022
cc513dc
syntax guard
tg123 Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/KubernetesClient.Models/IItems.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,12 @@ public interface IItems<T>
/// </summary>
IList<T> Items { get; set; }
}

public static class ItemsExt
{
public static IEnumerator<T> GetEnumerator<T>(this IItems<T> items)
{
return items.Items.GetEnumerator();
Copy link

@xiaomi7732 xiaomi7732 Jun 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, just curious, is it possible for items.Items to be null in any case? What is the expected behavior? Let it throw or gracefully quit the enumeration?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup you are right, would throw npe
maybe make it empty would be better

the issue now is that linq is not compatible with this impl

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we are looking for a cheap fix, my 2 cents if you don't mind:

  • I still think this is a good change even without linq because of the foreach improvement;
  • Linq could still be used on Items and I don't think it is too terrible:
podList.Items.Where(i => i.abc);  // Maybe not as perfect as podList.Where(i => ...) but I think it is okay.
  • Of course, that is based on the idea that interface IItems<T> : IEnumerable<T> looks like a sizable change, maybe there's an easier way to do it.

On a side note: if we can take a major refactor, why IItems<T>? Can't it be IEnumerable<T> to begin with?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am looking into templates to see if can put an IEnumerable there

}
}
}
22 changes: 22 additions & 0 deletions tests/KubernetesClient.Tests/ItemsEnumTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
using Xunit;
using k8s.Models;

namespace k8s.Tests;

public class ItemsEnumTests
{
[Fact]
public void EnsureIItemsEnumerable()
{
var pods = new V1PodList
{
Items = new[] { new V1Pod() },
};

// ensure no sytax err
foreach (var pod in pods)
{
Assert.NotNull(pod);
}
}
}