shortcut for iitem

[tg123]

fix #861
thank @WeihanLi for the idea

[tg123]

linq is not available anyway :(

[xiaomi7732]

Hi, just curious, is it possible for items.Items to be null in any case? What is the expected behavior? Let it throw or gracefully quit the enumeration?

[tg123]

yup you are right, would throw npe
maybe make it empty would be better

the issue now is that linq is not compatible with this impl

[xiaomi7732]

I assume we are looking for a cheap fix, my 2 cents if you don't mind:

• I still think this is a good change even without linq because of the foreach improvement;
• Linq could still be used on Items and I don't think it is too terrible:

podList.Items.Where(i => i.abc);  // Maybe not as perfect as podList.Where(i => ...) but I think it is okay.

• Of course, that is based on the idea that interface IItems<T> : IEnumerable<T> looks like a sizable change, maybe there's an easier way to do it.

On a side note: if we can take a major refactor, why IItems<T>? Can't it be IEnumerable<T> to begin with?

[tg123]

I am looking into templates to see if can put an IEnumerable there

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[tg123]

@brendanburns I believe this is ready for merge
any comments?

[brendandburns]

/lgtm
/approve

Thanks

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns,tg123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment