Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Golang to 1.23 and Spark to 3.5.2 #2150

Closed
wants to merge 2 commits into from
Closed

Update Golang to 1.23 and Spark to 3.5.2 #2150

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aae6455
Upgrade Go from 1.22.5 to 1.23.0
jacobsalway Sep 3, 2024
6f7336b
Update Spark from 3.5.0 to 3.5.2
jacobsalway Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Upgrade Go from 1.22.5 to 1.23.0 
Signed-off-by: Jacob Salway <jacob.salway@gmail.com>
  • Loading branch information
@jacobsalway
jacobsalway committed Sep 3, 2024
commit aae64553687095e7cce79f690f3eae16f7221f6c
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

ARG SPARK_IMAGE=spark:3.5.0

FROM golang:1.22.5 AS builder
FROM golang:1.23.0 AS builder

WORKDIR /workspace

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/kubeflow/spark-operator

go 1.22.5
go 1.23.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the minor version or can we use simply 1.23?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not strictly necessary given Go's backward compatibility guarantees and not pinning should reduce the frequency of toolchain upgrade PRs. Updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the patch version is needed, otherwise go mod tidy will fail:

$ go mod tidy
go: downloading go1.23 (darwin/arm64)
go: download go1.23 for darwin/arm64: toolchain not available

There are some issues related to the toolchain version not being available: golang/go#62278.


require (
cloud.google.com/go/storage v1.43.0
Expand Down