-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Golang to 1.23 and Spark to 3.5.2 #2150
Update Golang to 1.23 and Spark to 3.5.2 #2150
Conversation
Signed-off-by: Jacob Salway <jacob.salway@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
go.mod
Outdated
@@ -1,6 +1,6 @@ | |||
module github.com/kubeflow/spark-operator | |||
|
|||
go 1.22.5 | |||
go 1.23.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the minor version or can we use simply 1.23?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely not strictly necessary given Go's backward compatibility guarantees and not pinning should reduce the frequency of toolchain upgrade PRs. Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the patch version is needed, otherwise go mod tidy
will fail:
$ go mod tidy
go: downloading go1.23 (darwin/arm64)
go: download go1.23 for darwin/arm64: toolchain not available
There are some issues related to the toolchain version not being available: golang/go#62278.
Signed-off-by: Jacob Salway <jacob.salway@gmail.com>
857110f
to
6f7336b
Compare
@jacobsalway Could we have two dedicated PRs, one for bumping Golang version to 1.23.0, and another for bumping Spark version to 3.5.2. |
We should merge #2149 first so that the e2e test CI can pass. |
@ChenYi015 you'll need to get an approver to add the label on the other PR since I only have review permission |
@jacobsalway I had approved the e2e fix PR myself. |
I checked out the community guide and found that I can approve my PR, but I cannot lgtm my PR. |
Purpose
Upgrade Golang from 1.22.5 to 1.23 and Spark from 3.5.0 to 3.5.2, which includes both the Dockerfile and the examples.
Testing
examples/spark-pi-python.yaml
ran on Kind.--total-executor-cores
when deploying on K8s apache/spark#43536 but this flag isn't used when constructing thespark-submit
command internally)Change Category
Indicate the type of change by marking the applicable boxes:
Checklist
Before submitting your PR, please review the following: