Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore not found error in delete cluster #991

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Mar 19, 2019

This is required to workaround exit handler bug.


This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 19, 2019

This is required to workaround exit handler bug.

Can you explain a bit more in which circumstances does this but happen?

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 19, 2019

/test kubeflow-pipeline-e2e-test

@hongye-sun
Copy link
Contributor Author

Here is the issue: #999

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 82c7c17 into kubeflow:master Mar 19, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* fix minio storage test (kubeflow#1000)

* Pausing here. multiple CRDs of same name and different versions arent working

* Generated types

* Stopped generating v1alpha2 codegen

* Swapped v1alpha3 to v1beta1

* Adding initial v1beta1 controller interfaces

* Add grpc dependency

* Generate inference routes

* Fix crd generation

* Remove description for generated schema

* Add back contrainer spec generation

* Run deepcopy gen

* Fix inline schema

* v1beta1 codegen

* Support multiple crd versions

* Add back container for predictor spec

* Remove legacy crd directory

* Generate v1beta1 crd

* Use controller-runtime 0.4

* Move controller imp to separate PR

* Move inference routes apis to v1alpha1

* Update router api

* Update transformer and explainer

* Add canary traffic split

* Add routing matching rule

* torch serve container

* Add model server tests

* Add pipeline

* Fix v1beta1 examples

* Add comments on inference route type

* Move to advanced

* Add onnx test

* Fix logger

* Add defaulter tests

* Separate inference router

* Code generator for inference service

* Add component interface

* Add explainer test

* Add transformer tests

* Add predictor test

* Add explainer test

* Make runtimeVersion as *string

* Use reflector for interface nil check

* Add defauler tests

* Add validation tests

* Remove inference router

* Use helm v3.0.2

Co-authored-by: Yao Weng <wengyao04@gmail.com>
Co-authored-by: Ellis Tarn <ellistarn@gmail.com>
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* add alpha preview feature into compiler

* address comments

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants