Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated exit handler execution #999

Closed
hongye-sun opened this issue Mar 19, 2019 · 6 comments
Closed

Duplicated exit handler execution #999

hongye-sun opened this issue Mar 19, 2019 · 6 comments
Assignees
Labels
area/sdk/dsl kind/bug lifecycle/stale The issue / pull request is stale, any activities remove this label. priority/p1

Comments

@hongye-sun
Copy link
Contributor

Currently exit handler generated two steps in the generated argo yaml. One is at the start of the DAG and the other as the exit step.

https://screenshot.googleplex.com/n5qsgCJn3WU

@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

Could you please clarify the issue? I am not sure what this is about. Thanks!

@hongye-sun
Copy link
Contributor Author

Yes, the exit handler step will be executed twice in a pipeline. The first one is executed at the start of the pipeline and the second one is executed at the end of the pipeline. The second one is expected but the first one is not. The fix should remove the first step from the generated argo spec.

@vicaire
Copy link
Contributor

vicaire commented Mar 27, 2019

Thanks. Updated the area/priority

@vicaire vicaire changed the title Exit handler runs handler code at start of the DAG Duplicated exit handler execution May 31, 2019
@logicbomb421
Copy link

I'm also experiencing this issue.

A little more context:

I have a component that I load from component.py:

import kfp.components as components

def component_func(...):
    ...

op = components.func_to_container_op(
    component_func,
    ...
)

And in pipeline.py, I use the component like so:

import component
import kfp

@kfp.dsl.pipeline(...)
def pipeline_func(...):
    exit_handler = component.op(...)
    with kfp.dsl.ExitHandler(exit_handler):
        ...

When running a pipeline built this way, the exit handler is invoked immediately upon start, as well as upon exit.

@stale
Copy link

stale bot commented Jun 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 25, 2020
@stale
Copy link

stale bot commented Jul 3, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Jul 3, 2020
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdk/dsl kind/bug lifecycle/stale The issue / pull request is stale, any activities remove this label. priority/p1
Projects
None yet
Development

No branches or pull requests

3 participants