-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicated exit handler execution #999
Comments
Could you please clarify the issue? I am not sure what this is about. Thanks! |
Yes, the exit handler step will be executed twice in a pipeline. The first one is executed at the start of the pipeline and the second one is executed at the end of the pipeline. The second one is expected but the first one is not. The fix should remove the first step from the generated argo spec. |
Thanks. Updated the area/priority |
I'm also experiencing this issue. A little more context: I have a component that I load from import kfp.components as components
def component_func(...):
...
op = components.func_to_container_op(
component_func,
...
) And in import component
import kfp
@kfp.dsl.pipeline(...)
def pipeline_func(...):
exit_handler = component.op(...)
with kfp.dsl.ExitHandler(exit_handler):
... When running a pipeline built this way, the exit handler is invoked immediately upon start, as well as upon exit. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
Currently exit handler generated two steps in the generated argo yaml. One is at the start of the DAG and the other as the exit step.
https://screenshot.googleplex.com/n5qsgCJn3WU
The text was updated successfully, but these errors were encountered: