Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional pipeline_id to run_pipeline api #968

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Add optional pipeline_id to run_pipeline api #968

merged 1 commit into from
Mar 20, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Mar 14, 2019 •
edited by jlewi
Loading

This change is Reviewable

animeshsingh
animeshsingh reviewed Mar 14, 2019
View reviewed changes
Copy link
Contributor

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent of this would to run a sub pipeline from the main pipeline?

@hongye-sun
Copy link
Contributor Author

@animeshsingh No, it's for saving the traffic for clients which create a tons of runs from same template many times. They can upload the template once and repeatedly trigger the run from it. It's mostly useful with event triggered pipeline.

@gaoning777
Copy link
Contributor

/lgtm

@gaoning777
Copy link
Contributor

We need to add e2e tests for the python SDK in the future. Currently, we rely on the sample tests for many e2e test scenarios.

Thanks for the quick fix.

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor

I added an issue a few days ago to keep track.
#974

@k8s-ci-robot k8s-ci-robot merged commit dcdff39 into kubeflow:master Mar 20, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@zijianjoy
test(kfp): upgrade to 1.7.1 (kubeflow#968)
9c9a023 
* test(kfp): upgrade to 1.7.1

* make hydrate-kfp-manifests
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun
Update KFS 0.4 installation instruction (kubeflow#968)
d1974d0 
* Fix S3 secret keys

* Update KFServing 0.4 install instruction

* Use kfctl 1.1 branch for dex example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 left review comments

@animeshsingh animeshsingh animeshsingh left review comments

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@gaoning777 gaoning777

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hongye-sun @gaoning777 @k8s-ci-robot @animeshsingh