Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static type checking sample test #974

Closed
gaoning777 opened this issue Mar 15, 2019 · 3 comments
Closed

Add static type checking sample test #974

gaoning777 opened this issue Mar 15, 2019 · 3 comments
Assignees
@gaoning777

Comments

@gaoning777
Copy link
Contributor

A full coverage at the e2e tests help to identify the problems sooner.
And, adding basic sample tests as e2e tests also help to illustrate the features.
This was referenced Mar 15, 2019
Merged
Merged
@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

@gaoning777, could you please provide more details on the scope of this issue? Is it about improving e2e test coverage for everything? Or just some particular features or samples?

@vicaire vicaire added kind/tbd and removed kind/tbd labels Mar 26, 2019
@gaoning777
Copy link
Contributor Author

I added the issue such that the problems in the referenced PRs can be surfaced earlier.
Now changing the title to add a static type checking sample test.

@gaoning777 gaoning777 changed the title Optimize the E2E tests for a full coverage. Add static type checking sample test Mar 29, 2019
@gaoning777 gaoning777 mentioned this issue Apr 11, 2019
Merged
@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 11, 2019

AFAIK all current type checking code can be tested by unit-tests that do not require cluster.
If you want to test a sample notebook, it's easy to programmatically convert it to python and execute.

Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
@yuzisun
Upgrade go version to 1.17.3 (kubeflow#974)
9c4ad89
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@wzhanw
make cache to support multiple containers in task pod (kubeflow#974)
f043833 
* support multiple containers in task pod

* support multiple containers in task pod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaoning777 gaoning777

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ark-kun @gaoning777 @vicaire