Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components - Added the "Keras - Train classifier" component #809

Merged
merged 3 commits into from
Feb 25, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Feb 11, 2019

This change is Reviewable

@Ark-kun Ark-kun force-pushed the Added-sample-component branch 5 times, most recently from 3cd1f3c to 4344806 Compare February 12, 2019 19:48
Copy link
Contributor

@paveldournov paveldournov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

metrics=['accuracy'])

x_train = x_train.astype('float32')
x_train /= 255
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - why do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should remove this.
This is a bit of a leftover. When I was creating the sample I started from CIFAR dataset classifier training. It uses integer values for pixel colors, so the values are 0-255.
Usually people try to keep the activations around -1 .. 1, so they scale the inputs to that scale.
But this should probably be done on the network side.

@paveldournov
Copy link
Contributor

/lgtm

@paveldournov
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paveldournov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paveldournov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun Ark-kun changed the title [WIP] Added sample Keras - Train classifier component Added sample Keras - Train classifier component Feb 25, 2019
@Ark-kun Ark-kun changed the title Added sample Keras - Train classifier component [WIP]Added sample Keras - Train classifier component Feb 25, 2019
@Ark-kun Ark-kun changed the title [WIP]Added sample Keras - Train classifier component Added the "Keras - Train classifier" component Feb 25, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Feb 25, 2019

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 5c9b2d6 into kubeflow:master Feb 25, 2019
@Ark-kun Ark-kun changed the title Added the "Keras - Train classifier" component Components - Added the "Keras - Train classifier" component Mar 8, 2019
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
* Added sample component

* Replaced human-readable names with pythonic names

Some people are confused.

* Removed the tag from image name.
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* We should be using the issue-label-bot-user GCP SA as that's the cluster where
  its running.
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants