Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update GettingStarted.tsx #7254

Closed
wants to merge 2 commits into from

Conversation

rcrowe-google
Copy link

Updating link text and URL for TFX template launch.

Description of your changes:

Checklist:

Updating link text and URL for TFX template launch.
@google-oss-prow
Copy link

Hi @rcrowe-google. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rcrowe-google rcrowe-google changed the title Update GettingStarted.tsx fix: Update GettingStarted.tsx Feb 4, 2022
@rcrowe-google
Copy link
Author

/assign @zijianjoy

@zijianjoy
Copy link
Collaborator

Thank you @rcrowe-google , can you change Cloud Vertex AI Workbench to Vertex AI Workbench? Thank you!

@zijianjoy
Copy link
Collaborator

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 4, 2022
@google-oss-prow
Copy link

@rcrowe-google: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-frontend-test b2aa003 link true /test kubeflow-pipeline-frontend-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Changing "Cloud Vertex AI Workbench" to "Vertex AI Workbench"
@google-oss-prow google-oss-prow bot removed the lgtm label Feb 4, 2022
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from zijianjoy after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rcrowe-google
Copy link
Author

Thank you @rcrowe-google , can you change Cloud Vertex AI Workbench to Vertex AI Workbench? Thank you!

Yes, done.

@rcrowe-google
Copy link
Author

/assign @zijianjoy

@zijianjoy
Copy link
Collaborator

Thank you for your contribution and update! The fix has been merged with #7227. You can safely close this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants