Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fixes link to Vertex AI workbench in GettingStarted page. #7227

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

jiyongjung0
Copy link
Contributor

@jiyongjung0 jiyongjung0 commented Jan 28, 2022

Cloud AI Platform Notebook was migrated to Vertex AI workbench and the URL has changed.

Description of your changes:

Checklist:

Cloud AI Platform Notebook was migrated to Vertex AI workbench and the URL has changed.
@google-oss-prow
Copy link

Hi @jiyongjung0. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zijianjoy
Copy link
Collaborator

/ok-to-test

@zijianjoy
Copy link
Collaborator

/lgtm
/approve

Thank you Jiyong for keeping documentaiton up-to-date!

@zijianjoy
Copy link
Collaborator

For the test failure:

Run npm run test and update snapshot based on instruction.

@google-oss-prow google-oss-prow bot removed the lgtm label Feb 3, 2022
@jiyongjung0
Copy link
Contributor Author

/retest

I tried to run npm run test but couldn't install dependent packages. I just manually updated relevant data. Please create a separate PR if this approach is not right.

@zijianjoy
Copy link
Collaborator

/lgtm
/approve

You probably need to install package using npm ci.

But it is all good now as you fixed it, thank you!

@google-oss-prow google-oss-prow bot added the lgtm label Feb 4, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiyongjung0
Copy link
Contributor Author

/retest

@google-oss-prow google-oss-prow bot merged commit 145bc23 into kubeflow:master Feb 4, 2022
@zijianjoy zijianjoy mentioned this pull request Feb 4, 2022
1 task
@zijianjoy zijianjoy mentioned this pull request Feb 7, 2022
6 tasks
chensun pushed a commit that referenced this pull request Feb 8, 2022
…ge. (#7227)

* Fixes link to Vertex AI workbench.

Cloud AI Platform Notebook was migrated to Vertex AI workbench and the URL has changed.

* Fixes test data.
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
…ge. (kubeflow#7227)

* Fixes link to Vertex AI workbench.

Cloud AI Platform Notebook was migrated to Vertex AI workbench and the URL has changed.

* Fixes test data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants