Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch from go dep to go module #581

Merged
merged 14 commits into from
Dec 22, 2018
Merged

switch from go dep to go module #581

merged 14 commits into from
Dec 22, 2018

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Dec 21, 2018 •
edited by jlewi
Loading

This change is Reviewable

@IronPan IronPan changed the title add vendor to gitignore [WIP] add vendor to gitignore Dec 21, 2018
@IronPan
Copy link
Member Author

IronPan commented Dec 21, 2018

/assign @yebrahim @neuromage

@yebrahim
Copy link
Contributor

This would be awesome if we can pull it off.
Shouldn't you be deleting the existing vendor directory? Otherwise all code references would still be using those packages no?

@IronPan IronPan changed the title [WIP] add vendor to gitignore [WIP] switch from go dep to go module Dec 21, 2018
@IronPan IronPan changed the title [WIP] switch from go dep to go module switch from go dep to go module Dec 21, 2018
@IronPan
Copy link
Member Author

IronPan commented Dec 21, 2018

/test kubeflow-pipeline-e2e-test

@neuromage
Copy link
Contributor

This is great, thanks for doing this! I had started to work on this change myself, but realized I needed a good way to keep the build reproducible. Right now, the hack in the api/Makefile relies on specific versions of code-generation tools located under vendor/. With go modules, my plan was to use Bazel to achieve the same effect. Right now, as is, I think this part will be broken. But I will try to fix it asap based off this change.

@neuromage
Copy link
Contributor

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Dec 21, 2018

/test kubeflow-pipeline-e2e-test

1 similar comment
@IronPan
Copy link
Member Author

IronPan commented Dec 21, 2018

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 21, 2018
@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 21, 2018

Fixes #187

@yebrahim
Copy link
Contributor

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Dec 22, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yebrahim
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit e7af132 into kubeflow:master Dec 22, 2018
@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 26, 2018

Does the Makefile still work for you? /cc @IronPan

@neuromage
Copy link
Contributor

Without vendoring, the Makefile will no longer work. I'm working on a PR right now to fix this properly. Sorry for the trouble @Ark-kun

@andreyvelich andreyvelich mentioned this pull request Apr 24, 2019
Closed
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@hougangliu @k8s-ci-robot
Skip get inferenceservice-config configmap for non-kfserving pod (kub…
9dd0900 
…eflow#581)

* Skip get inferenceservice-config configmap for non-kfserving pod

* refactor needMutate
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli @drewbutlerbb4
Add instructions on upgrade kfp-tekton multi-users and fix new multi-…
c1b4d84 
…users permission (kubeflow#581)

* add instrctions on upgrade kfp-tekton and fix multi-users permission

* Apply suggestions from code review

Co-authored-by: Andrew Butler <Andrew.Butler@ibm.com>

* Fix markdown links after suggestions

Co-authored-by: Andrew Butler <Andrew.Butler@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qimingj qimingj Awaiting requested review from qimingj

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@neuromage neuromage

@yebrahim yebrahim

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IronPan @yebrahim @neuromage @Ark-kun @k8s-ci-robot