Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Go 1.11 modules and package management. #187

Closed
Ark-kun opened this issue Nov 9, 2018 · 7 comments
Closed

Switch to Go 1.11 modules and package management. #187

Ark-kun opened this issue Nov 9, 2018 · 7 comments
Assignees
@IronPan
Labels
area/backend

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 9, 2018

See https://github.com/golang/go/wiki/Modules

Argo has just switched recently: https://github.com/argoproj/argo/pull/1071/files
@vicaire vicaire removed their assignment Nov 12, 2018
@vicaire
Copy link
Contributor

vicaire commented Nov 12, 2018

Modules are experimental in Go 1.11 and will be finalized in Go 1.12.

I would propose that we don't use this feature until it is finalized.

https://github.com/golang/go/wiki/Modules

@vicaire vicaire closed this as completed Nov 12, 2018
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 21, 2018

/reopen

@k8s-ci-robot
Copy link
Contributor

@Ark-kun: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

@Ark-kun: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Dec 21, 2018
@Ark-kun Ark-kun mentioned this issue Dec 21, 2018
Merged
@yebrahim
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@yebrahim: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

@yebrahim: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@ellistarn @k8s-ci-robot
Update Owners (kubeflow#187)
532882e 
I think this is long overdue. WDYT?
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@ckadner
Update E2E tests (kubeflow#187)
e509aeb 
- Break up test cases into 2 sub-tests:
  1. Validate Tekton YAML
  2. Verify PipelineRun logs
- Delete tasks before running pipeline
- Normalize UUID before comparing logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IronPan IronPan

Labels
area/backend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yebrahim @Ark-kun @IronPan @k8s-ci-robot @vicaire