Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): clean up backend code generation #5116

Merged
merged 13 commits into from
Feb 9, 2021

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Feb 9, 2021

Description of your changes:
Changes:

  • Prefer downloading required tools than building via bazel.
  • Clean up proto unused imports (but I found error.proto imports are required).
  • Remove licenses from generated code, because that's no longer required.
  • Remove BUILD.bazel files that are no longer used.

Checklist:

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 9, 2021

/cc @NikeNano

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 9, 2021

Changes to remove importing error package is reverted, because after that, I get the following error during swagger generation:

/tmp/tmp.nP3pFaOTw6/swagger_linux_amd64 generate client -f /home/gongyuan_google_com/kfp/pipelines/backend/api/swagger/pipeline.swagger.json -A pipeline --principal models.Principal -c pipeline_client -m pipeline_model -t /home/gongyuan_google_com/kfp/pipelines/backend/api/go_http_client
2021/02/09 09:19:23 validating spec /home/gongyuan_google_com/kfp/pipelines/backend/api/swagger/pipeline.swagger.json
The swagger spec at "/home/gongyuan_google_com/kfp/pipelines/backend/api/swagger/pipeline.swagger.json" is invalid against swagger specification 2.0. see errors :
- invalid ref ".api.Status"
- ```

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 9, 2021

OK, if tests pass, I think this is ready to merge.

Then the follow up PRs to remove bazel should contain minimal changes: either #4906 or #5115

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 9, 2021

/assign @NikeNano
Can you help me review and LGTM?

Copy link
Member

@NikeNano NikeNano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, NikeNano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, NikeNano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 3d40bba into kubeflow:master Feb 9, 2021
@Bobgy Bobgy deleted the bazel-cleanup branch February 9, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants