Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - chore(backend): remove bazel from backend code generation #5115

Closed
wants to merge 55 commits into from

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Feb 9, 2021

Description of your changes:
This is my attempt forking from #4906.

Run the following to generate

# cd backend/api
docker build ../.. -t builder -f ../Dockerfile.buildapi
./generate_api.sh

Checklist:

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 9, 2021

/cc @NikeNano
I put up a working version

@google-cla
Copy link

google-cla bot commented Feb 9, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 9, 2021
@@ -0,0 +1,119 @@
#!/bin/bash

# Copyright 2018-2020 Google LLC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we generally do with updating licenses?

Copy link
Contributor Author

@Bobgy Bobgy Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually update the date to include the last year there's a change, so we should update this as
Copyright 2020-2021 The Kubeflow Authors, because you created it.

@google-oss-robot
Copy link

@Bobgy: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pipeline-backend-test 1e7a338 link /test kubeflow-pipeline-backend-test
kubeflow-pipeline-sample-test 1e7a338 link /test kubeflow-pipeline-sample-test
kubeflow-pipeline-upgrade-test 1e7a338 link /test kubeflow-pipeline-upgrade-test
kubeflow-pipeline-e2e-test 1e7a338 link /test kubeflow-pipeline-e2e-test
kubeflow-pipeline-frontend-test 1e7a338 link /test kubeflow-pipeline-frontend-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-cla
Copy link

google-cla bot commented Feb 10, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@Bobgy Bobgy closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants