Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fire dependency in the component image build #384

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 26, 2018

This change is Reviewable

@gaoning777
Copy link
Contributor Author

/test presubmit-e2e-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 26, 2018

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cc38ca0 into master Nov 27, 2018
@gaoning777 gaoning777 deleted the ngao/remove-fire-componentbuild branch November 27, 2018 00:39
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Adding new approvers for efficiency.
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* Add build test for apiserver, agent, and workflow

* Separate backend build steps

* Rename backend build targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants