Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python fire interprets string incorrectly #318

Closed
gaoning777 opened this issue Nov 19, 2018 · 2 comments
Closed

Python fire interprets string incorrectly #318

gaoning777 opened this issue Nov 19, 2018 · 2 comments
Assignees
@gaoning777
Labels
area/sdk/components

Comments

@gaoning777
Copy link
Contributor

According to the Python fire argument parsing guide(https://github.com/google/python-fire/blob/master/docs/guide.md#argument-parsing). Some strings might be incorrectly interpreted, then purified.
For example, Amy recently had a problem of passing 1.10 as the argument but it unfortunately interpreted as float and passed as 1.1 to the container.
@gaoning777
Copy link
Contributor Author

gaoning777 commented Nov 26, 2018 •
edited
Loading

solved by PR: #384
@amygdala

@gaoning777 gaoning777 self-assigned this Nov 26, 2018
@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 4, 2018

Fixed

@Ark-kun Ark-kun closed this as completed Dec 4, 2018
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
@zhenghuiwang @k8s-ci-robot
Automate new project creation (kubeflow#318)
3fcfd0d 
* project creation

* merge master

* add readme

* fix lint

* lint
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@Tomcli
Fix big data annotations and update docs/samples (kubeflow#318)
5f189b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaoning777 gaoning777

Labels
area/sdk/components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ark-kun @gaoning777