Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue with footer overlapping side panel and fixes summary layout #353

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Fixes issue with footer overlapping side panel and fixes summary layout #353

merged 2 commits into from
Nov 21, 2018

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Nov 21, 2018 •
edited
Loading

This is a follow-up to #305

This change is Reviewable

@rileyjbauer rileyjbauer mentioned this pull request Nov 21, 2018
Merged
ajayalfred
ajayalfred reviewed Nov 21, 2018
View reviewed changes
Copy link
Contributor

@ajayalfred ajayalfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Glad to see the info text right-aligned.
Some small tweaks:

  1. Pls change icon size to 16x x 16px. Currently its 24px x 13px.
  2. Font-family="Roboto" for text is being overwritten by something and so its defaulting to Google Sans

@rileyjbauer
Copy link
Contributor Author

@ajayalfred, requested changes have been made

@ajayalfred
Copy link
Contributor

Looks great! thanks.

yebrahim
yebrahim reviewed Nov 21, 2018
View reviewed changes
Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yebrahim
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 21, 2018
@yebrahim
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 1e5ad47 into master Nov 21, 2018
@IronPan IronPan deleted the cleanup-pipeline-summary branch June 28, 2019 18:46
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@gabrielwen @k8s-ci-robot
Undelete endpoint service for testing cluster. (kubeflow#353)
8fc5398 
* fix project args

* undelete endpoint service

* fix

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajayalfred ajayalfred ajayalfred left review comments

@yebrahim yebrahim yebrahim left review comments

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@yebrahim yebrahim

Labels
approved area/frontend lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rileyjbauer @ajayalfred @yebrahim @k8s-ci-robot