Changes "Hide" button on Pipeline summary to fully hide the paper card #305
Conversation
| fontSize: fontsize.small, | ||
| lineHeight: '24px', | ||
| paddingLeft: 6, | ||
| }, | ||
| nodeName: { |
There was a problem hiding this comment.
I think we need to shake down the summaryCard class, it has unneeded rules now.
There was a problem hiding this comment.
I think I can remove backgroundColor, maxHeight, and overflow. Was there anything else you were thinking?
|
/lgtm cancel |
Now, when the summary is hidden, a "Show summary" button will appear at the bottom of the graph to reopen the card. Additionally, added a small note reading "Static pipeline graph" to the bottom of the graph
rileyjbauer
force-pushed
the
hide-pipeline-graph-summary
branch
from
dade0af
to
9def4c1
Compare
There was a problem hiding this comment.
Looks good. It's a little strange that the (i) info text moves under the overlay when expanded. If its possible to make it appear to the right of the expanded overlay, that would be ideal.
That said, I will be proposing some UX changes to this page to improve usability. So this layout change may not be necessary at the moment.
For the info text ("Static pipeline graph"), please use this style – Roboto Regular, 12px, #80868b, letter-spacing: 0.21px
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rileyjbauer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@ajayalfred, I've made the changes you suggested, including moving the info text to the right of the summary card in #353. Please take a look |
* Update UI to get archived logs if available * Fix formatting * Add note in admin guide * Add note in admin guide * Fix typo from kubeflow#299 and lint format * Add bracket
Fixes: #289
Now, when the summary is hidden, a "Show summary" button will appear at the bottom of the graph to reopen the card.
Additionally, added a small note reading "Static pipeline graph" to the bottom of the graph.
Summary shown:
Summary hidden:
This change is