Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Use new released kfp-server-api package #3224

Merged
merged 4 commits into from
Mar 11, 2020
Merged

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Mar 6, 2020

/assign @numerology

We should release a patched kfp shortly after then.
Context: #2977 (comment)
We should change kfp package dependency when releasing a new kfp-server-api package.


This change is Reviewable

@numerology
Copy link

Sorry can you point me to the PR where the server API was changed? Just want to double check if it's backward compatible :)

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 6, 2020

Sorry can you point me to the PR where the server API was changed? Just want to double check if it's backward compatible :)

It's released to pypi directly, code is not checked in here.

@numerology
Copy link

Sorry can you point me to the PR where the server API was changed? Just want to double check if it's backward compatible :)

It's released to pypi directly, code is not checked in here.

I see. My understanding is that, because currently in SDK we don't have something like upload_pipeline_version yet, it's okay to declare the backward compatibility. Once we have that, we'll need to bump the lower bound version, right?

Otherwise LGTM

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 6, 2020

@numerology That's a good point, we already have schedule_pipeline method that uses the new no_catchup field: #3201.

We need to increase lower bound version.

sdk/python/setup.py Outdated Show resolved Hide resolved
@IronPan
Copy link
Member

IronPan commented Mar 6, 2020

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 10, 2020

You should probably use kfp-server-api==0.2.5 syntax.

@numerology
Copy link

You should probably use kfp-server-api==0.2.5 syntax.

Good catch :) Also make sure there is no space around the '=='

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 11, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 11, 2020

Thanks @Ark-kun and @numerology! Does this look good now?

@numerology
Copy link

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 11, 2020

Let's resolve the Travis test issues first to avoid upsetting the Prow team.
/hold

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 11, 2020

@Bobgy Please change requirements.txt accordingly to avoid version conflicts.

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 11, 2020

Sorry I didn't realize it failed, will fix this

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 11, 2020
@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 11, 2020

Sorry I didn't realize it failed, will fix this

The issue was unexpected. It won't reproduce locally. It seems to be a weird issue in pip triggered by travis: github.com/pypa/pip/issues/6275

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot merged commit f8a4521 into master Mar 11, 2020
@Bobgy Bobgy deleted the Bobgy-patch-1 branch March 11, 2020 08:52
@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 11, 2020

Thanks! I thought the error was caused by version inconsistency between requirements.txt and setup.py. Looks like it's not expected.

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 11, 2020

Thanks! I thought the error was caused by version inconsistency between requirements.txt and setup.py. Looks like it's not expected.

It was a trigger, but usually pip does not stop on those version errors.

Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* [SDK] Use new released kfp-server-api package

/assign @numerology

* Update setup.py

* Update setup.py

* Fix requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants