-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Use new released kfp-server-api package #3224
Conversation
Sorry can you point me to the PR where the server API was changed? Just want to double check if it's backward compatible :) |
It's released to pypi directly, code is not checked in here. |
I see. My understanding is that, because currently in SDK we don't have something like Otherwise LGTM |
@numerology That's a good point, we already have We need to increase lower bound version. |
/lgtm |
You should probably use |
Good catch :) Also make sure there is no space around the '==' |
Thanks @Ark-kun and @numerology! Does this look good now? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Let's resolve the Travis test issues first to avoid upsetting the Prow team. |
@Bobgy Please change requirements.txt accordingly to avoid version conflicts. |
Sorry I didn't realize it failed, will fix this |
The issue was unexpected. It won't reproduce locally. It seems to be a weird issue in pip triggered by travis: github.com/pypa/pip/issues/6275 /hold cancel |
Thanks! I thought the error was caused by version inconsistency between requirements.txt and setup.py. Looks like it's not expected. |
It was a trigger, but usually pip does not stop on those version errors. |
* [SDK] Use new released kfp-server-api package /assign @numerology * Update setup.py * Update setup.py * Fix requirements.txt
/assign @numerology
We should release a patched kfp shortly after then.
Context: #2977 (comment)
We should change kfp package dependency when releasing a new kfp-server-api package.
This change is