-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] New fields for schedule pipeline #3201
[SDK] New fields for schedule pipeline #3201
Conversation
sdk/python/kfp/_client.py
Outdated
no_catchup {[type]} -- Whether the recurring run should catch up if behind schedule. | ||
For example, if the recurring run is paused for a while and re-enabled | ||
afterwards. If no_catchup=False, the scheduler will catch up on (backfill) each | ||
missed interval. Otherwise, it only schedules the latest interval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to make sure I understand it correctly. 'latest interval' actually means 'current interval', right? And the behavior should be if no_catchup
, then the run won't trigger or backfilled right after this request, instead it will wait for the next trigger time from now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, it will backfill the latest recent interval immediately: https://airflow.apache.org/docs/stable/scheduler.html#backfill-and-catchup
Thanks! @Bobgy LGTM modulo two nit comments. |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* [SDK] New fields for schedule pipeline * Update according to CR comments * Update snapshot
Fixes #3055
/assign @numerology
/assign @Ark-kun
This change is