Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] New fields for schedule pipeline #3201

Merged

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Mar 3, 2020

Fixes #3055

/assign @numerology
/assign @Ark-kun


This change is Reviewable

sdk/python/kfp/_client.py Outdated Show resolved Hide resolved
no_catchup {[type]} -- Whether the recurring run should catch up if behind schedule.
For example, if the recurring run is paused for a while and re-enabled
afterwards. If no_catchup=False, the scheduler will catch up on (backfill) each
missed interval. Otherwise, it only schedules the latest interval.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to make sure I understand it correctly. 'latest interval' actually means 'current interval', right? And the behavior should be if no_catchup, then the run won't trigger or backfilled right after this request, instead it will wait for the next trigger time from now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, it will backfill the latest recent interval immediately: https://airflow.apache.org/docs/stable/scheduler.html#backfill-and-catchup

@numerology
Copy link

Thanks! @Bobgy

LGTM modulo two nit comments.

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 4, 2020

/approve
for frontend change

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Mar 4, 2020
@numerology
Copy link

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 75b5fd7 into kubeflow:master Mar 4, 2020
@Bobgy Bobgy deleted the sdk_new_fields_schedule_pipeline branch March 11, 2020 04:28
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* [SDK] New fields for schedule pipeline

* Update according to CR comments

* Update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduled workflow catchup=false behavior like airflow
4 participants