Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Fixed the broken kfp.gcp.use_preemptible_nodepool extension #3091

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Feb 14, 2020

It was generating broken Kubernetes structures that made the workflow fail at submission time.

Fixes #2847


This change is Reviewable

It was generating broken Kubernetes structures that made the workflow fail at submission time.

Fixes kubeflow#2847
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Feb 14, 2020

/approve

@numerology
Copy link

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 839198f into kubeflow:master Feb 15, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
…beflow#3091)

It was generating broken Kubernetes structures that made the workflow fail at submission time.

Fixes kubeflow#2847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload error when using gcp.use_preemptible_nodepool()
3 participants