SDK - Fixed the broken kfp.gcp.use_preemptible_nodepool extension (#3091

) It was generating broken Kubernetes structures that made the workflow fail at submission time. Fixes #2847
kubeflow · Feb 15, 2020 · 839198f · 839198f
1 parent 06c03f9
commit 839198f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/sdk/python/kfp/gcp.py b/sdk/python/kfp/gcp.py
@@ -112,9 +112,10 @@ def _set_preemptible(task):
       node_affinity = V1NodeAffinity(required_during_scheduling_ignored_during_execution=
                         V1NodeSelector(node_selector_terms=[node_selector_term]))
     else:
-      node_affinity = V1NodeAffinity(preferred_during_scheduling_ignored_during_execution=
+      node_affinity = V1NodeAffinity(preferred_during_scheduling_ignored_during_execution=[
                         V1PreferredSchedulingTerm(preference=node_selector_term,
-                                                  weight=50))
+                                                  weight=50)
+      ])
     affinity = V1Affinity(node_affinity=node_affinity)
     task.add_affinity(affinity=affinity)
     return task

diff --git a/sdk/python/tests/compiler/testdata/preemptible_tpu_gpu.yaml b/sdk/python/tests/compiler/testdata/preemptible_tpu_gpu.yaml
@@ -13,7 +13,7 @@ spec:
     - affinity:
         nodeAffinity:
           preferredDuringSchedulingIgnoredDuringExecution:
-            preference:
+          - preference:
               matchExpressions:
                 - key: cloud.google.com/gke-preemptible
                   operator: In