Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add myself to manifest/sample/test owner #3027

Merged
merged 1 commit into from
Feb 12, 2020
Merged

add myself to manifest/sample/test owner #3027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions manifests/kustomize/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ approvers:
reviewers:
- Bobgy
- IronPan
- rmgogogo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a confirmation, will you have capacity to review all of these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks strange you ask this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it. I meant you are adding yourself as reviewer for a lot of folders, that seems a lot of work to review all those PRs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason is detailed in https://github.com/kubeflow/pipelines/pull/2893/files.
As tech leader and hosted owner, I need to well track the possible breaking changes, especially preloaded samples and manifest. Test (Rui's work can help a lot) also should be well take care. Our post-submit always fail now. Manifest is not well managed. We don't have sense to make the manifest change be back-compatible. Any of these would make hosted broken. Rui's test can help but test can't cover all things. Put me to reviewer list to keep an eye is a good approch. As for workload, definitelly still lever dedicated owners for a detailed review.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmgogogo Thanks for the explanation! Sounds good to me.

2 changes: 2 additions & 0 deletions samples/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@ approvers:
- gaoning777
- hongye-sun
- numerology
- rmgogogo
reviewers:
- Ark-kun
- gaoning777
- hongye-sun
- animeshsingh
- numerology
- rmgogogo
2 changes: 2 additions & 0 deletions test/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ approvers:
- gaoning777
- IronPan
- numerology
- rmgogogo
reviewers:
- Ark-kun
- Bobgy
- gaoning777
- IronPan
- numerology
- rmgogogo