add myself to manifest/sample/test owner #3027
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -5,3 +5,4 @@ approvers: | |||
| reviewers: | |||
| - Bobgy | |||
| - IronPan | |||
| - rmgogogo | |||
There was a problem hiding this comment.
Just a confirmation, will you have capacity to review all of these?
There was a problem hiding this comment.
looks strange you ask this
There was a problem hiding this comment.
I don't get it. I meant you are adding yourself as reviewer for a lot of folders, that seems a lot of work to review all those PRs
There was a problem hiding this comment.
The reason is detailed in https://github.com/kubeflow/pipelines/pull/2893/files.
As tech leader and hosted owner, I need to well track the possible breaking changes, especially preloaded samples and manifest. Test (Rui's work can help a lot) also should be well take care. Our post-submit always fail now. Manifest is not well managed. We don't have sense to make the manifest change be back-compatible. Any of these would make hosted broken. Rui's test can help but test can't cover all things. Put me to reviewer list to keep an eye is a good approch. As for workload, definitelly still lever dedicated owners for a detailed review.
There was a problem hiding this comment.
@rmgogogo Thanks for the explanation! Sounds good to me.
|
/retest |
Co-authored-by: renmingu <40223865+renmingu@users.noreply.github.com>
* update version number to 0.11-rc1 Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * generate install v0.11.0-rc1 Signed-off-by: Tessa Pham <hpham111@bloomberg.net> --------- Signed-off-by: Tessa Pham <hpham111@bloomberg.net>
PR is moved from https://github.com/kubeflow/pipelines/pull/2893/files
That PR has CLA issue while after I follow the guide, it still can't be fixed. So copy out a new PR and submit
This change is