Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload local file as new pipeline version Step 2 - Swagger generated code for UploadPipelineVersion method #3010

Merged

Conversation

jingzhang36
Copy link
Contributor

@jingzhang36 jingzhang36 commented Feb 7, 2020

Previous step (Step 1) is at #3001

Step 3 would be adding UploadPipelineVersion to pipeline upload client.
Step 4 would be frontend sending POST request to endpoint /upload_version under pipeline upload service.

Context: #2977

This change is Reviewable

@jingzhang36 jingzhang36 changed the title Swagger generated code for UploadPipelineVersion method Upload local file as new pipeline version Step 2 - Swagger generated code for UploadPipelineVersion method Feb 7, 2020
@jingzhang36
Copy link
Contributor Author

/assign @Bobgy
/assign @IronPan

@Bobgy
Copy link
Contributor

Bobgy commented Feb 7, 2020

/lgtm
Because this is all generated

@IronPan
Copy link
Member

IronPan commented Feb 7, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Feb 8, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 96f1e4d into kubeflow:master Feb 8, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Remove distutils from Python SDK

Signed-off-by: Xin Fu <xfu83@bloomberg.net>

* Clean up extra bracket

Signed-off-by: Xin Fu <xfu83@bloomberg.net>

---------

Signed-off-by: Xin Fu <xfu83@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants