Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload local file as new pipeline version Step 1 #3001

Merged
merged 5 commits into from
Feb 7, 2020

Conversation

jingzhang36
Copy link
Contributor

@jingzhang36 jingzhang36 commented Feb 6, 2020

Add UploadPipelineVersion method to pipeline upload server/service.

Step 2 would be using swagger-gen to update go_client and go_http_client.
Step 3 would be adding UploadPipelineVersion to pipeline upload client.
Step 4 would be frontend sending POST request to endpoint /upload_version under pipeline upload service.

Context: #2977


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jingzhang36
You can assign the PR to them by writing /assign @jingzhang36 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jingzhang36
Copy link
Contributor Author

/assign @Bobgy
/assign @IronPan

@jingzhang36
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@jingzhang36
Copy link
Contributor Author

/assign @Bobgy
/assign @IronPan

@Bobgy
Copy link
Contributor

Bobgy commented Feb 7, 2020

/lgtm

@jingzhang36 jingzhang36 merged commit d1b72df into kubeflow:master Feb 7, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* add upload pipeline version to upload_pipeline_server and http main

* add apiPipelineVersion to pipeline upload swagger json

* add apiResourceReference to pipeline upload swagger json

* Add yet more types to pipeline upload swagger json

* Unit tests
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Updated onnx-example.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Updated model storage uri

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Updated onnx yaml and notebook.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

---------

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants