Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix][Test] Fix post submit test on mkp deployment #2939

Merged
merged 15 commits into from
Jan 30, 2020
Merged

[Fix][Test] Fix post submit test on mkp deployment #2939

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6c9f6a9
Add mkp deployment for test
rui5i Jan 11, 2020
8d1a2ba
Add mkp deployment script
rui5i Jan 15, 2020
8ec580b
Add sleep 60 after kfp deployment
rui5i Jan 15, 2020
23b2100
Typo fix
rui5i Jan 15, 2020
bf223f1
Remove cluster deployment and argo installation in mkp script
rui5i Jan 15, 2020
901d945
Revert unrelated changes
rui5i Jan 16, 2020
626e0d2
Add kfp deployment options param in post submit script
rui5i Jan 16, 2020
b02d026
Remove WI set up on mkp deployment
rui5i Jan 17, 2020
96c6dbe
Merge remote-tracking branch 'upstream/master' into mkp-post-submit
rui5i Jan 21, 2020
41ba392
Fix on naming and syntax
rui5i Jan 21, 2020
b8ab7fd
Merge branch 'master' of https://github.com/kubeflow/pipelines into m…
rui5i Jan 22, 2020
7a9c38f
Merge remote-tracking branch 'origin/mkp-post-submit' into mkp-deploy
rui5i Jan 22, 2020
6bb9e1e
Read marketplace tools image from dockerfile
rui5i Jan 22, 2020
830cd4d
Merge branch 'master' of https://github.com/kubeflow/pipelines into m…
rui5i Jan 30, 2020
6d46ea5
Fix post submit test
rui5i Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Read marketplace tools image from dockerfile 
This commit changes marketplace tool image name from hard-coded to be
read from manifest.
  • Loading branch information
@rui5i
rui5i committed Jan 22, 2020
commit 6bb9e1e8a9f545349d7c1c671369738bc3457822
9 changes: 4 additions & 5 deletions test/deploy-pipeline-mkp-cli.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,20 +38,19 @@ export APP_INSTANCE_NAME=kubeflow-pipelines-test

# Install mpdev
BIN_FILE="$HOME/bin/mpdev"
KFP_MANIFEST_DIR=${DIR}/../manifests/gcp_marketplace

if ! which mpdev; then
echo "Install mpdev"
docker pull gcr.io/cloud-marketplace-tools/k8s/dev
mkdir -p $HOME/bin/
touch $BIN_FILE
export PATH=$HOME/bin:$PATH
docker run gcr.io/cloud-marketplace-staging/marketplace-k8s-app-tools/k8s/dev:remove-ui-ownerrefs cat /scripts/dev > "$BIN_FILE"
MKP_TOOLS_IMAGE=`grep -i "FROM" ${KFP_MANIFEST_DIR}/deployer/Dockerfile | sed 's/FROM //'`
docker run ${MKP_TOOLS_IMAGE} cat /scripts/dev > "$BIN_FILE"
chmod +x "$BIN_FILE"
fi

export MARKETPLACE_TOOLS_TAG=remove-ui-ownerrefs
export MARKETPLACE_TOOLS_IMAGE=gcr.io/cloud-marketplace-staging/marketplace-k8s-app-tools/k8s/dev

KFP_MANIFEST_DIR=${DIR}/../manifests/gcp_marketplace
pushd ${KFP_MANIFEST_DIR}
# Update the version value on schema.yaml and application.yaml
sed -ri 's/publishedVersion:.*/publishedVersion: '"$GCR_IMAGE_TAG"'/' schema.yaml
Expand Down