[Fix][Test] Fix post submit test on mkp deployment #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds mkp deployment script including cluster deployment, argo installation and kfp mkp deployment.
This commits adds sleep 60 after kfp deployment to make sure kfp resources are ready when running argo submit.
This commit removes cluster deployment and argo installation in mkp script. Those logic are the same with before and can use existing script.
This commit reverts unrelated changes on test/manifests/kustomization.yaml.
This commit adds kfp deployment options in post submit script. Current options are standalone and mkp deployment.
This commit removes WI set up on mkp deployment.
This commit fixes small naming and syntax problem pointed on PR review.
This commit changes marketplace tool image name from hard-coded to be read from manifest.
This commit fixes post submit on mkp deployment when running docker. The base image didn't set up avoiding using sudo when running docker.
|
/assign @numerology |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* Add mkp deployment for test * Add mkp deployment script This commit adds mkp deployment script including cluster deployment, argo installation and kfp mkp deployment. * Add sleep 60 after kfp deployment This commits adds sleep 60 after kfp deployment to make sure kfp resources are ready when running argo submit. * Typo fix This commit fixes zone variable and deletes extra comments. * Remove cluster deployment and argo installation in mkp script This commit removes cluster deployment and argo installation in mkp script. Those logic are the same with before and can use existing script. * Revert unrelated changes This commit reverts unrelated changes on test/manifests/kustomization.yaml. * Add kfp deployment options param in post submit script This commit adds kfp deployment options in post submit script. Current options are standalone and mkp deployment. * Remove WI set up on mkp deployment This commit removes WI set up on mkp deployment. * Fix on naming and syntax This commit fixes small naming and syntax problem pointed on PR review. * Read marketplace tools image from dockerfile This commit changes marketplace tool image name from hard-coded to be read from manifest. * Fix post submit test This commit fixes post submit on mkp deployment when running docker. The base image didn't set up avoiding using sudo when running docker.
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes post-submit test on mkp deployment.
Background: https://screenshot.googleplex.com/VKbJMBEfvYx
Root cause: Base image doesn't have docker post-install set up and doesn't allow run docker without sudo.
This change is