SDK/Components - Switching to map-based syntax for the arguments. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list-based syntax is going to be deprecated.
qimingj
approved these changes
Nov 5, 2018
|
/approve /LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qimingj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
changed the title
|
/lgtm |
Ark-kun
deleted the
avolkov/Switching-to-map-based-syntax-for-the-arguments
branch
Realsen
added a commit
to Realsen/pipelines
that referenced
this pull request
Feb 1, 2020
k8s-ci-robot
pushed a commit
that referenced
this pull request
Feb 3, 2020
* Basic prototype * Get kfpPodName from RunDetails page * disable tfma visualization * Refactor more stuff * Remove MLMD protos * Adapt to kubeflow/frontend PR #29 * Don't throw errors if artifacts and contexts are not in MLMD * Revert unnecessary changes * Update package.json to include the latest kubeflow/frontend commit * Restore changes to package.json and package-lock.json * Address comments * Use new TS syntax for concatenating lists, as per @Bobgy's suggestion * Use @Bobgy's suggestion to re-throw exceptions with error messages * Catch all exceptions and return an empty list for them. * npm run format * use === instead of == * Apply suggestions from code review * Fix @kubeflow/frontend by using a forked fix * Fix unit test failure * Fixed error handling and code clean up * Restructure output artifact loader to change detailed implementation as local functions instead of public static methods. Co-authored-by: Yuan (Bob) Gong <gongyuan94@gmail.com>
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* Basic prototype * Get kfpPodName from RunDetails page * disable tfma visualization * Refactor more stuff * Remove MLMD protos * Adapt to kubeflow/frontend PR kubeflow#29 * Don't throw errors if artifacts and contexts are not in MLMD * Revert unnecessary changes * Update package.json to include the latest kubeflow/frontend commit * Restore changes to package.json and package-lock.json * Address comments * Use new TS syntax for concatenating lists, as per @Bobgy's suggestion * Use @Bobgy's suggestion to re-throw exceptions with error messages * Catch all exceptions and return an empty list for them. * npm run format * use === instead of == * Apply suggestions from code review * Fix @kubeflow/frontend by using a forked fix * Fix unit test failure * Fixed error handling and code clean up * Restructure output artifact loader to change detailed implementation as local functions instead of public static methods. Co-authored-by: Yuan (Bob) Gong <gongyuan94@gmail.com>
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
Would like to provide a link to workflow URLs in gubernator. Changes made: Pass ui_urls into create_finished to use in the metadata.
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Mark Knative serving service and kfservice clear in log * rename KFService to kfserving service in log
HumairAK
referenced
this pull request
in red-hat-data-services/data-science-pipelines
Mar 11, 2024
Updating image name in Makefile
HumairAK
added a commit
to HumairAK/data-science-pipelines
that referenced
this pull request
May 10, 2024
UPSTREAM: <carry>: chore: add meaningful logs to client initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list-based syntax is going to be deprecated soon.
This change is