Skip to content

Commit

Permalink
Add support for automatic visualization of TFX artifacts (kubeflow#2957)
Browse files Browse the repository at this point in the history
* Basic prototype

* Get kfpPodName from RunDetails page

* disable tfma visualization

* Refactor more stuff

* Remove MLMD protos

* Adapt to kubeflow/frontend PR kubeflow#29

* Don't throw errors if artifacts and contexts are not in MLMD

* Revert unnecessary changes

* Update package.json to include the latest kubeflow/frontend commit

* Restore changes to package.json and package-lock.json

* Address comments

* Use new TS syntax for concatenating lists, as per @Bobgy's suggestion

* Use @Bobgy's suggestion to re-throw exceptions with error messages

* Catch all exceptions and return an empty list for them.

* npm run format

* use === instead of ==

* Apply suggestions from code review

* Fix @kubeflow/frontend by using a forked fix

* Fix unit test failure

* Fixed error handling and code clean up

* Restructure output artifact loader to change detailed implementation as local functions instead of public static methods.

Co-authored-by: Yuan (Bob) Gong <gongyuan94@gmail.com>
  • Loading branch information
2 people authored and Jeffwan committed Dec 9, 2020
1 parent 10ac486 commit 326bb68
Show file tree
Hide file tree
Showing 11 changed files with 10,952 additions and 27,168 deletions.
36,569 changes: 10,621 additions & 25,948 deletions frontend/package-lock.json

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"@kubeflow/frontend": "kubeflow/frontend#756476a",
"@kubeflow/frontend": "github:Bobgy/frontend#36d6d1",
"@material-ui/core": "3.7.1",
"@material-ui/icons": "^3.0.1",
"@types/js-yaml": "^3.11.2",
Expand All @@ -19,15 +19,15 @@
"markdown-to-jsx": "^6.10.3",
"portable-fetch": "^3.0.0",
"re-resizable": "^4.9.0",
"react": "^16.7.0",
"react": "^16.12.0",
"react-ace": "^7.0.2",
"react-dom": "^16.5.2",
"react-dom": "^16.12.0",
"react-dropzone": "^5.1.0",
"react-router-dom": "^4.3.1",
"react-scripts-ts": "2.17.0",
"react-virtualized": "^9.20.1",
"react-vis": "^1.11.2",
"typestyle": "^2.0.1"
"typestyle": "^2.0.4"
},
"scripts": {
"analyze-bundle": "node analyze_bundle.js",
Expand Down
28 changes: 0 additions & 28 deletions frontend/src/apis/metadata/BUILD.bazel

This file was deleted.

Loading

0 comments on commit 326bb68

Please sign in to comment.