Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visualization server wants kubernetes serivce account too #2822

Merged
merged 4 commits into from
Jan 12, 2020
Merged

visualization server wants kubernetes serivce account too #2822

merged 4 commits into from
Jan 12, 2020

Conversation

jingzhang36
Copy link
Contributor

@jingzhang36 jingzhang36 commented Jan 10, 2020 •
edited by jlewi
Loading

This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Jan 10, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Bobgy
To complete the pull request process, please assign ironpan
You can assign the PR to them by writing /assign @ironpan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Jan 10, 2020

@rmgogogo Can you approve too?

@jingzhang36 jingzhang36 merged commit a8bd3ae into kubeflow:master Jan 12, 2020
rui5i pushed a commit to rui5i/pipelines that referenced this pull request Jan 16, 2020
@jingzhang36 @rui5i
visualization server wants kubernetes serivce account too (kubeflow#2822
854f152 
)

* visualization server wants kubernetes serivce account too

* add ksa for visualization server and use this ksa for standalone and
hosted deployment of visualization server

* Use server name its ksa name

* add sa to pipeline.yaml
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@jingzhang36 @Jeffwan
visualization server wants kubernetes serivce account too (kubeflow#2822
4d55eb4 
)

* visualization server wants kubernetes serivce account too

* add ksa for visualization server and use this ksa for standalone and
hosted deployment of visualization server

* Use server name its ksa name

* add sa to pipeline.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Bobgy left review comments

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@Bobgy Bobgy

Labels
lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jingzhang36 @Bobgy @k8s-ci-robot