Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visualization server wants kubernetes serivce account too #2822

Merged
merged 4 commits into from
Jan 12, 2020
Merged

visualization server wants kubernetes serivce account too #2822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccafc77
visualization server wants kubernetes serivce account too
jingzhang36 Jan 10, 2020
17518c4
add ksa for visualization server and use this ksa for standalone and
jingzhang36 Jan 10, 2020
4144a4c
Use server name its ksa name
jingzhang36 Jan 10, 2020
1614d4d
add sa to pipeline.yaml
jingzhang36 Jan 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions manifests/gcp_marketplace/chart/kubeflow-pipelines/templates/pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ metadata:
---
apiVersion: v1
kind: ServiceAccount
metadata:
name: ml-pipeline-visualizationserver
labels:
app.kubernetes.io/name: {{ .Release.Name }}
---
apiVersion: v1
kind: ServiceAccount
metadata:
name: ml-pipeline
labels:
Expand Down Expand Up @@ -608,6 +615,7 @@ spec:
name: ml-pipeline-visualizationserver
ports:
- containerPort: 8888
serviceAccountName: ml-pipeline-visualizationserver
jingzhang36 marked this conversation as resolved.
Show resolved Hide resolved
---
apiVersion: apps/v1beta2
kind: Deployment
Expand Down
1 change: 1 addition & 0 deletions manifests/kustomize/base/pipeline/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ resources:
- ml-pipeline-viewer-crd-deployment.yaml
- ml-pipeline-viewer-crd-sa.yaml
- ml-pipeline-visualization-deployment.yaml
- ml-pipeline-visualization-sa.yaml
- ml-pipeline-visualization-service.yaml
- pipeline-runner-role.yaml
- pipeline-runner-rolebinding.yaml
Expand Down
1 change: 1 addition & 0 deletions manifests/kustomize/base/pipeline/ml-pipeline-visualization-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ spec:
name: ml-pipeline-visualizationserver
ports:
- containerPort: 8888
serviceAccountName: ml-pipeline-visualizationserver
4 changes: 4 additions & 0 deletions manifests/kustomize/base/pipeline/ml-pipeline-visualization-sa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
apiVersion: v1
kind: ServiceAccount
metadata:
name: ml-pipeline-visualizationserver
2 changes: 1 addition & 1 deletion manifests/kustomize/gcp-workload-identity-setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ SYSTEM_GSA=${SYSTEM_GSA:-$CLUSTER_NAME-kfp-system}
USER_GSA=${USER_GSA:-$CLUSTER_NAME-kfp-user}

# Kubernetes Service Account (KSA)
SYSTEM_KSA=(ml-pipeline-ui)
jingzhang36 marked this conversation as resolved.
Show resolved Hide resolved
SYSTEM_KSA=(ml-pipeline-ui ml-pipeline-visualizationserver)
USER_KSA=(pipeline-runner default) # default service account is used for container building, TODO: give it a specific name

cat <<EOF
Expand Down