Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert sample test to mitigate test flakiness #277

Merged
merged 6 commits into from
Nov 15, 2018
Merged

Revert sample test to mitigate test flakiness #277

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2dd451f
[WIP] change deployment platform to gcp
IronPan Nov 14, 2018
d7d35bf
debug
IronPan Nov 14, 2018
f33cb44
Merge branch 'master' of https://github.com/kubeflow/pipelines
IronPan Nov 15, 2018
38b6cdc
revert test
IronPan Nov 15, 2018
a3e704c
Update presubmit-tests.sh
IronPan Nov 15, 2018
ab6c150
Update deploy.sh
IronPan Nov 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 61 additions & 60 deletions test/e2e_test_gke.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,66 +125,67 @@ spec:
#TODO: Uncomment to disable the test on Minikube
#TODO: Change the cluster-type to "minikube" once https://github.com/kubeflow/pipelines/pull/1285 and related PRs are merged.
#when: "{{workflow.parameters.cluster-type}} != none" #Do not run the test on Minikube
- name: run-condition-tests
template: run-basic-e2e-tests
arguments:
parameters:
- name: commit-sha
value: "{{inputs.parameters.commit-sha}}"
- name: test-results-gcs-dir
value: "{{inputs.parameters.test-results-gcs-dir}}"
- name: sample-tests-image
value: "gcr.io/{{steps.get-project.outputs.result}}/{{inputs.parameters.commit-sha}}/{{inputs.parameters.basic-e2e-tests-image-suffix}}"
- name: test-name
value: "condition"
- name: run-exit-handler-tests
template: run-basic-e2e-tests
arguments:
parameters:
- name: commit-sha
value: "{{inputs.parameters.commit-sha}}"
- name: test-results-gcs-dir
value: "{{inputs.parameters.test-results-gcs-dir}}"
- name: sample-tests-image
value: "gcr.io/{{steps.get-project.outputs.result}}/{{inputs.parameters.commit-sha}}/{{inputs.parameters.basic-e2e-tests-image-suffix}}"
- name: test-name
value: "exithandler"
- name: run-sequential-tests
template: run-basic-e2e-tests
arguments:
parameters:
- name: commit-sha
value: "{{inputs.parameters.commit-sha}}"
- name: test-results-gcs-dir
value: "{{inputs.parameters.test-results-gcs-dir}}"
- name: sample-tests-image
value: "gcr.io/{{steps.get-project.outputs.result}}/{{inputs.parameters.commit-sha}}/{{inputs.parameters.basic-e2e-tests-image-suffix}}"
- name: test-name
value: "sequential"
- name: run-immediate-value-tests
template: run-basic-e2e-tests
arguments:
parameters:
- name: commit-sha
value: "{{inputs.parameters.commit-sha}}"
- name: test-results-gcs-dir
value: "{{inputs.parameters.test-results-gcs-dir}}"
- name: sample-tests-image
value: "gcr.io/{{steps.get-project.outputs.result}}/{{inputs.parameters.commit-sha}}/{{inputs.parameters.basic-e2e-tests-image-suffix}}"
- name: test-name
value: "immediatevalue"
- name: run-parallel-join-tests
template: run-basic-e2e-tests
arguments:
parameters:
- name: commit-sha
value: "{{inputs.parameters.commit-sha}}"
- name: test-results-gcs-dir
value: "{{inputs.parameters.test-results-gcs-dir}}"
- name: sample-tests-image
value: "gcr.io/{{steps.get-project.outputs.result}}/{{inputs.parameters.commit-sha}}/{{inputs.parameters.basic-e2e-tests-image-suffix}}"
- name: test-name
value: "paralleljoin"
# TODO: Re-enable when https://github.com/kubeflow/pipelines/issues/272 is clear
# - name: run-condition-tests
# template: run-basic-e2e-tests
# arguments:
# parameters:
# - name: commit-sha
# value: "{{inputs.parameters.commit-sha}}"
# - name: test-results-gcs-dir
# value: "{{inputs.parameters.test-results-gcs-dir}}"
# - name: sample-tests-image
# value: "gcr.io/{{steps.get-project.outputs.result}}/{{inputs.parameters.commit-sha}}/{{inputs.parameters.basic-e2e-tests-image-suffix}}"
# - name: test-name
# value: "condition"
# - name: run-exit-handler-tests
# template: run-basic-e2e-tests
# arguments:
# parameters:
# - name: commit-sha
# value: "{{inputs.parameters.commit-sha}}"
# - name: test-results-gcs-dir
# value: "{{inputs.parameters.test-results-gcs-dir}}"
# - name: sample-tests-image
# value: "gcr.io/{{steps.get-project.outputs.result}}/{{inputs.parameters.commit-sha}}/{{inputs.parameters.basic-e2e-tests-image-suffix}}"
# - name: test-name
# value: "exithandler"
# - name: run-sequential-tests
# template: run-basic-e2e-tests
# arguments:
# parameters:
# - name: commit-sha
# value: "{{inputs.parameters.commit-sha}}"
# - name: test-results-gcs-dir
# value: "{{inputs.parameters.test-results-gcs-dir}}"
# - name: sample-tests-image
# value: "gcr.io/{{steps.get-project.outputs.result}}/{{inputs.parameters.commit-sha}}/{{inputs.parameters.basic-e2e-tests-image-suffix}}"
# - name: test-name
# value: "sequential"
# - name: run-immediate-value-tests
# template: run-basic-e2e-tests
# arguments:
# parameters:
# - name: commit-sha
# value: "{{inputs.parameters.commit-sha}}"
# - name: test-results-gcs-dir
# value: "{{inputs.parameters.test-results-gcs-dir}}"
# - name: sample-tests-image
# value: "gcr.io/{{steps.get-project.outputs.result}}/{{inputs.parameters.commit-sha}}/{{inputs.parameters.basic-e2e-tests-image-suffix}}"
# - name: test-name
# value: "immediatevalue"
# - name: run-parallel-join-tests
# template: run-basic-e2e-tests
# arguments:
# parameters:
# - name: commit-sha
# value: "{{inputs.parameters.commit-sha}}"
# - name: test-results-gcs-dir
# value: "{{inputs.parameters.test-results-gcs-dir}}"
# - name: sample-tests-image
# value: "gcr.io/{{steps.get-project.outputs.result}}/{{inputs.parameters.commit-sha}}/{{inputs.parameters.basic-e2e-tests-image-suffix}}"
# - name: test-name
# value: "paralleljoin"

- name: get-project
script:
Expand Down